Don't leak buffer if an error occurs.

2007-11-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbuilder.c (gtk_builder_add_from_file): Don't
        leak buffer if an error occurs.

svn path=/trunk/; revision=18979

diff --git a/ChangeLog b/ChangeLog
index 700d68e2e6ff2afe28c0d25c87c8f47e870c3f68..c81caf337096f3f4c05e082ce6ab99e880fbf64b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-11-10  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtkbuilder.c (gtk_builder_add_from_file): Don't
+       leak buffer if an error occurs.  
+
 2007-11-09  Matthias Clasen  <mclasen@redhat.com>
        
        * gtk/gtkbuilderparser.c: More robustness improvements

diff --git a/gtk/gtkbuilder.c b/gtk/gtkbuilder.c
index a5c9fd683feb23a5b77512af9b07dc1494f739d2..f7dd41b502e51fceb1ed4c2041fecbe82f15544f 100644 (file)
--- a/gtk/gtkbuilder.c
+++ b/gtk/gtkbuilder.c
@@ -667,14 +667,14 @@ gtk_builder_add_from_file (GtkBuilder   *builder,
                                     buffer, length,
                                     &tmp_error);
 
+  g_free (buffer);
+
   if (tmp_error != NULL)
     {
       g_propagate_error (error, tmp_error);
       return 0;
     }
 
-  g_free (buffer);
-
   return 1;
 }